[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 0/5] virtio-input; live migration support, variou
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 0/5] virtio-input; live migration support, various bugfixes. |
Date: |
Mon, 11 Apr 2016 16:17:09 +0100 |
On 11 April 2016 at 16:12, Gerd Hoffmann <address@hidden> wrote:
>> Hi. I'm afraid this doesn't compile on ppc64be:
>>
>> /home/pm215/qemu/hw/input/virtio-input-hid.c:487:9: error: suggest
>> parentheses around ‘-’ in operand of ‘&’ [-Werror=parentheses]
>> .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE - 1),
>> ^
>> /home/pm215/qemu/hw/input/virtio-input-hid.c:492:9: error: suggest
>> parentheses around ‘-’ in operand of ‘&’ [-Werror=parentheses]
>> .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE - 1),
>> ^
>>
>> It looks like the const_le32() and const_le16() macros in
>> include/hw/virtio/virtio-input.h are missing brackets around the macro
>> argument
>
> Indeed. /me needs a be machine.
If you have access to the gcc compile farm, there's a ppc64be
box in it.
> Suggestions for a better place? Looks like there isn't something like
> byteorder.h ...
include/qemu/bswap.h.
thanks
-- PMM
- [Qemu-devel] [PULL 0/5] virtio-input; live migration support, various bugfixes., Gerd Hoffmann, 2016/04/11
- [Qemu-devel] [PULL 2/5] virtio-input: retrieve EV_LED host config bits, Gerd Hoffmann, 2016/04/11
- [Qemu-devel] [PULL 1/5] virtio-input: add missing key mappings, Gerd Hoffmann, 2016/04/11
- [Qemu-devel] [PULL 3/5] virtio-input: implement pass-through evdev writes, Gerd Hoffmann, 2016/04/11
- [Qemu-devel] [PULL 4/5] virtio-input: add live migration support, Gerd Hoffmann, 2016/04/11
- [Qemu-devel] [PULL 5/5] virtio-input: fix emulated tablet axis ranges, Gerd Hoffmann, 2016/04/11
- Re: [Qemu-devel] [PULL 0/5] virtio-input; live migration support, various bugfixes., Peter Maydell, 2016/04/11