[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2 09/11] tcg: add kick timer for single-threaded
From: |
Sergey Fedorov |
Subject: |
Re: [Qemu-devel] [RFC v2 09/11] tcg: add kick timer for single-threaded vCPU emulation |
Date: |
Tue, 12 Apr 2016 00:39:55 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 05/04/16 18:32, Alex Bennée wrote:
> +static void kick_tcg_thread(void *opaque)
> +{
> + QEMUTimer *self = *(QEMUTimer **) opaque;
> + timer_mod(self,
> + qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) +
> + NANOSECONDS_PER_SECOND / 10);
> + qemu_cpu_kick_no_halt();
> +}
>
It would be nice to have some definition (e.g. macro) of TCG thread kick
period.
(snip)
> @@ -1179,6 +1198,14 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)
> }
> }
>
> + /* Set to kick if we have to do more than one vCPU */
> + if (CPU_NEXT(first_cpu)) {
> + kick_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, kick_tcg_thread,
> &kick_timer);
> + timer_mod(kick_timer,
> + qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) +
> + NANOSECONDS_PER_SECOND / 10);
> + }
> +
I think cpu_ticks_init() could be more natural place to put this
initialization in.
Kind regards,
Sergey
- [Qemu-devel] [RFC v2 00/11] Base enabling patches for MTTCG, Alex Bennée, 2016/04/05
- [Qemu-devel] [RFC v2 05/11] tcg: protect TBContext with tb_lock., Alex Bennée, 2016/04/05
- [Qemu-devel] [RFC v2 09/11] tcg: add kick timer for single-threaded vCPU emulation, Alex Bennée, 2016/04/05
- Re: [Qemu-devel] [RFC v2 09/11] tcg: add kick timer for single-threaded vCPU emulation,
Sergey Fedorov <=
- [Qemu-devel] [RFC v2 06/11] target-arm/psci.c: wake up sleeping CPUs, Alex Bennée, 2016/04/05
- [Qemu-devel] [RFC v2 02/11] cpus: make all_vcpus_paused() return bool, Alex Bennée, 2016/04/05
- [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG, Alex Bennée, 2016/04/05
- Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG, Sergey Fedorov, 2016/04/11
- Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG, Alex Bennée, 2016/04/12
- Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG, Peter Maydell, 2016/04/12
- Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG, Sergey Fedorov, 2016/04/12
- Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG, KONRAD Frederic, 2016/04/12
- Re: [Qemu-devel] [RFC v2 08/11] tcg: add options for enabling MTTCG, Sergey Fedorov, 2016/04/12