[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 05/10] tcg: Clarify thread safety check in tb_add
From: |
Sergey Fedorov |
Subject: |
[Qemu-devel] [PATCH v4 05/10] tcg: Clarify thread safety check in tb_add_jump() |
Date: |
Thu, 21 Apr 2016 00:15:16 +0300 |
From: Sergey Fedorov <address@hidden>
The check is to make sure that another thread hasn't already done the
same while we were outside of tb_lock. Mention this in a comment.
Signed-off-by: Sergey Fedorov <address@hidden>
Signed-off-by: Sergey Fedorov <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
---
Changes in v2:
* Typo fixed in the commit title
* Complete rewrite of the commit body and the patch based on Paolo's comments
include/exec/exec-all.h | 29 ++++++++++++++++-------------
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
index 03b177b0cac5..0e9f630b5a43 100644
--- a/include/exec/exec-all.h
+++ b/include/exec/exec-all.h
@@ -391,20 +391,23 @@ static inline void tb_set_jmp_target(TranslationBlock *tb,
static inline void tb_add_jump(TranslationBlock *tb, int n,
TranslationBlock *tb_next)
{
- /* NOTE: this test is only needed for thread safety */
- if (!tb->jmp_list_next[n]) {
- qemu_log_mask_and_addr(CPU_LOG_EXEC, tb->pc,
- "Linking TBs %p [" TARGET_FMT_lx
- "] index %d -> %p [" TARGET_FMT_lx "]\n",
- tb->tc_ptr, tb->pc, n,
- tb_next->tc_ptr, tb_next->pc);
- /* patch the native jump address */
- tb_set_jmp_target(tb, n, (uintptr_t)tb_next->tc_ptr);
-
- /* add in TB jmp circular list */
- tb->jmp_list_next[n] = tb_next->jmp_list_first;
- tb_next->jmp_list_first = (uintptr_t)tb | n;
+ if (tb->jmp_list_next[n]) {
+ /* Another thread has already done this while we were
+ * outside of the lock; nothing to do in this case */
+ return;
}
+ qemu_log_mask_and_addr(CPU_LOG_EXEC, tb->pc,
+ "Linking TBs %p [" TARGET_FMT_lx
+ "] index %d -> %p [" TARGET_FMT_lx "]\n",
+ tb->tc_ptr, tb->pc, n,
+ tb_next->tc_ptr, tb_next->pc);
+
+ /* patch the native jump address */
+ tb_set_jmp_target(tb, n, (uintptr_t)tb_next->tc_ptr);
+
+ /* add in TB jmp circular list */
+ tb->jmp_list_next[n] = tb_next->jmp_list_first;
+ tb_next->jmp_list_first = (uintptr_t)tb | n;
}
/* GETRA is the true target of the return instruction that we'll execute,
--
2.8.1
- [Qemu-devel] [PATCH v4 09/10] tcg: Clean up direct block chaining safety checks, (continued)
- [Qemu-devel] [PATCH v4 03/10] tcg: Rearrange tb_link_page() to avoid forward declaration, Sergey Fedorov, 2016/04/20
- [Qemu-devel] [PATCH v4 04/10] tcg: Init TB's direct jumps before making it visible, Sergey Fedorov, 2016/04/20
- [Qemu-devel] [PATCH v4 01/10] tcg: Clean up direct block chaining data fields, Sergey Fedorov, 2016/04/20
- [Qemu-devel] [PATCH v4 10/10] tcg: Allow goto_tb to any target PC in user mode, Sergey Fedorov, 2016/04/20
- [Qemu-devel] [PATCH v4 05/10] tcg: Clarify thread safety check in tb_add_jump(),
Sergey Fedorov <=
- [Qemu-devel] [PATCH v4 06/10] tcg: Rename tb_jmp_remove() to tb_remove_from_jmp_list(), Sergey Fedorov, 2016/04/20
- [Qemu-devel] [PATCH v4 07/10] tcg: Extract removing of jumps to TB from tb_phys_invalidate(), Sergey Fedorov, 2016/04/20
- Re: [Qemu-devel] [PATCH v4 00/10] tcg: Direct block chaining clean-up, Alex Bennée, 2016/04/28