Re: [Qemu-devel] [PATCH v5] Add optionrom compatible with fw_cfg DMA version

[Richard W.M. Jones]

On Tue, Apr 26, 2016 at 09:43:09AM +0200, Gerd Hoffmann wrote:
> On Fr, 2016-04-22 at 14:02 +0100, Richard W.M. Jones wrote:
> > v4 -> v5:
> > 
> >  * Fix the initrd loading problem by fixing the get_e801_addr
> >    function so it really reads the values from the BIOS.
> > 
> > Previously the function always returned 16MB, and so it only happened
> > to work for initrd sizes < ~15MB, and broke for anything larger.  Now
> > the function is fixed, I tested it on 20MB & 350KB initrds and it
> > worked for both.
> 
> Can confirm it works, and with a big initramfs it is a very noticable
> speedup.
> 
> >  * Fix the Win32 cross-compiler issue by making the 'ld -m' (emulator)
> >    option conditional on CONFIG_WIN32.
> > 
> > This change was not tested with the cross-compiler.  Gerd, could you
> > see if this fixes things?
> 
> Yes, it builds fine now.
> 
> Only thing I've noticed is that I have to manually copy the rom to
> pc-bios/, I guess we want place a pre-compiled binary there like we do
> for the other option roms.

Yes, I noticed this too (on Linux non-cross-compiles).  Not sure if
that's right or wrong.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org