Re: [Qemu-devel] [PATCH v16 20/24] qapi: Don't pass NULL to printf in string input visitor

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> Make sure the error message for visit_type_uint64() gracefully
> handles a NULL 'name' when called from the top level or a list
> context, as not all the world behaves like glibc in allowing
> NULL through a printf-family %s.
>
> Signed-off-by: Eric Blake <address@hidden>
>
> ---
> v16: split off NULL handling
> v15: new patch
> ---
>  qapi/string-input-visitor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c
> index 797973a..b55d199 100644
> --- a/qapi/string-input-visitor.c
> +++ b/qapi/string-input-visitor.c
> @@ -222,7 +222,7 @@ static void parse_type_int64(Visitor *v, const char 
> *name, int64_t *obj,
>      return;
>
>  error:
> -    error_setg(errp, QERR_INVALID_PARAMETER_VALUE, name,
> +    error_setg(errp, QERR_INVALID_PARAMETER_VALUE, name ? name : "null",
>                 "an int64 value or range");
>  }

Crash bug, nominating the fix for 2.6 (I'll post a pull request), or
else -stable.

Reviewed-by: Markus Armbruster <address@hidden>