[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v16 00/24] qapi visitor cleanups (post-introspec
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v16 00/24] qapi visitor cleanups (post-introspection cleanups subset E) |
|
Date: |
Wed, 4 May 2016 08:07:33 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/04/2016 07:54 AM, Markus Armbruster wrote:
> Uh, in visitor.h at the end of this series:
>
> * <example>
> * Visitor *v;
> * Error *err = NULL;
> * int value;
> *
> * v = ...obtain visitor...
> * visit_start_struct(v, NULL, NULL, 0, &err);
> * if (err) {
> ---> goto outobj;
> * outobj:
> * visit_end_struct(v);
> * error_propagate(errp, err);
> * ...clean up v...
> * </example>
>
> The ---> goto is wrong; we call visit_end_struct() after
> visit_start_struct() failed. Haven't dug through the patches to find
> the guilty one.
>
Fairly easy fix, and only affects doc (patch 12/24 introduced it). I've
sent a fixup that you can squash in, since qapi-next is not merged to
master yet.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature