[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 20/52] target-m68k: Remove incorrect clearing of cc_
From: |
Laurent Vivier |
Subject: |
[Qemu-devel] [PATCH 20/52] target-m68k: Remove incorrect clearing of cc_x |
Date: |
Wed, 4 May 2016 22:12:00 +0200 |
From: Richard Henderson <address@hidden>
The CF docs certainly doesnt suggest this is true.
Signed-off-by: Richard Henderson <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
target-m68k/helper.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/target-m68k/helper.c b/target-m68k/helper.c
index ffed180..9c14d6f 100644
--- a/target-m68k/helper.c
+++ b/target-m68k/helper.c
@@ -206,19 +206,12 @@ static uint32_t cpu_m68k_flush_flags(CPUM68KState *env,
int op)
break;
case CC_OP_LOGICB:
SET_NZ(dest, int8_t);
- goto set_x;
break;
case CC_OP_LOGICW:
SET_NZ(dest, int16_t);
- goto set_x;
break;
case CC_OP_LOGIC:
SET_NZ(dest, int32_t);
-set_x:
- if (!m68k_feature(env, M68K_FEATURE_M68000)) {
- /* Unlike m68k, coldfire always clears the overflow bit. */
- env->cc_x = 0;
- }
break;
case CC_OP_ADDB:
SET_FLAGS_ADD(int8_t, uint8_t);
--
2.5.5
- Re: [Qemu-devel] [PATCH 13/52] target-m68k: update CPU flags management, (continued)
- [Qemu-devel] [PATCH 14/52] target-m68k: update move to/from ccr/sr, Laurent Vivier, 2016/05/04
- [Qemu-devel] [PATCH 15/52] target-m68k: don't update cc_dest in helpers, Laurent Vivier, 2016/05/04
- [Qemu-devel] [PATCH 17/52] target-m68k: Print flags properly, Laurent Vivier, 2016/05/04
- [Qemu-devel] [PATCH 16/52] target-m68k: update CPU flags management, Laurent Vivier, 2016/05/04
- [Qemu-devel] [PATCH 18/52] target-m68k: Some fixes to SR and flags management, Laurent Vivier, 2016/05/04
- [Qemu-devel] [PATCH 20/52] target-m68k: Remove incorrect clearing of cc_x,
Laurent Vivier <=
- [Qemu-devel] [PATCH 19/52] target-m68k: terminate cpu dump with newline, Laurent Vivier, 2016/05/04
- [Qemu-devel] [PATCH 22/52] target-m68k: Introduce DisasCompare, Laurent Vivier, 2016/05/04
- [Qemu-devel] [PATCH 23/52] target-m68k: Use setcond for scc, Laurent Vivier, 2016/05/04
- [Qemu-devel] [PATCH 21/52] target-m68k: Reorg flags handling, Laurent Vivier, 2016/05/04
- [Qemu-devel] [PATCH 24/52] target-m68k: Optimize some comparisons, Laurent Vivier, 2016/05/04
- [Qemu-devel] [PATCH 25/52] target-m68k: Optimize gen_flush_flags, Laurent Vivier, 2016/05/04
- [Qemu-devel] [PATCH 26/52] target-m68k: Inline shifts, Laurent Vivier, 2016/05/04