[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 10/11] pci core: assert ENOSPC when add capabilit
From: |
Cao jin |
Subject: |
[Qemu-devel] [PATCH v5 10/11] pci core: assert ENOSPC when add capability |
Date: |
Fri, 6 May 2016 12:20:41 +0800 |
ENOSPC is programming error, assert it for debugging.
cc: Michael S. Tsirkin <address@hidden>
cc: Marcel Apfelbaum <address@hidden>
cc: Markus Armbruster <address@hidden>
Signed-off-by: Cao jin <address@hidden>
---
hw/pci/pci.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index f0f41dc..fc8b377 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -2151,10 +2151,8 @@ int pci_add_capability2(PCIDevice *pdev, uint8_t cap_id,
if (!offset) {
offset = pci_find_space(pdev, size);
- if (!offset) {
- error_setg(errp, "out of PCI config space");
- return -ENOSPC;
- }
+ /* out of PCI config space should be programming error */
+ assert(offset);
} else {
/* Verify that capabilities don't overlap. Note: device assignment
* depends on this check to verify that the device is not broken.
--
2.1.0
- Re: [Qemu-devel] [PATCH v5 09/11] pci bridge dev: change msi property type, (continued)
[Qemu-devel] [PATCH v5 07/11] mptsas: change msi property type, Cao jin, 2016/05/06
[Qemu-devel] [PATCH v5 05/11] usb xhci: change msi/msix property type, Cao jin, 2016/05/06
[Qemu-devel] [PATCH v5 01/11] fix some coding style problems, Cao jin, 2016/05/06
[Qemu-devel] [PATCH v5 06/11] intel-hda: change msi property type, Cao jin, 2016/05/06
[Qemu-devel] [PATCH v5 08/11] megasas: change msi/msix property type, Cao jin, 2016/05/06
[Qemu-devel] [PATCH v5 10/11] pci core: assert ENOSPC when add capability,
Cao jin <=
[Qemu-devel] [PATCH v5 11/11] pci: Convert msi_init() to Error and fix callers to check it, Cao jin, 2016/05/06
[Qemu-devel] [PATCH v5 03/11] megasas: Fix, Cao jin, 2016/05/06