[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v3] translate-all: protect code_gen_buffer with RC
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC v3] translate-all: protect code_gen_buffer with RCU |
Date: |
Mon, 9 May 2016 13:21:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 30/04/2016 05:40, Emilio G. Cota wrote:
>> The tb_flush
>> > is a fairly rare occurrence its not like its on the critical performance
>> > path (although of course pathological cases are possible).
> This is what I thought from the beginning, but wanted to give this
> alternative a go anyway to see if it was feasible.
>
> On my end I won't do any more work on this approach. Will go back
> to locks, despite Paolo's (justified) dislike for them =)
Which locks? tb_lock during tb_find_fast? The problem with that was
that it slowed down everything a lot, wasn't it?
To me, the RCU idea is not really about making tb_flush (the rare case)
faster; it was more about keeping the rest simple and fast.
Paolo
- Re: [Qemu-devel] [RFC v3] translate-all: protect code_gen_buffer with RCU,
Paolo Bonzini <=