[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-io: Fix memory leak in 'aio_write -z'
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-io: Fix memory leak in 'aio_write -z' |
Date: |
Mon, 9 May 2016 08:47:37 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/09/2016 04:03 AM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> qemu-io-cmds.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <address@hidden>
Perhaps it would be easier to convert all the mid-function returns into
'goto cleanup', so that we don't have to repeat the cleanups everywhere,
but that's more invasive.
>
> diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
> index e34f777..41580b5 100644
> --- a/qemu-io-cmds.c
> +++ b/qemu-io-cmds.c
> @@ -1699,6 +1699,7 @@ static int aio_write_f(BlockBackend *blk, int argc,
> char **argv)
> int64_t count = cvtnum(argv[optind]);
> if (count < 0) {
> print_cvtnum_err(count, argv[optind]);
> + g_free(ctx);
> return 0;
> }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature