[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions |
Date: |
Mon, 9 May 2016 16:25:15 -0300 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Mon, May 09, 2016 at 09:20:15AM -0600, Eric Blake wrote:
> On 05/06/2016 12:11 PM, Eduardo Habkost wrote:
> > Extend query-cpu-definitions schema to allow it to return two new
> > optional fields: "runnable" and "unavailable-features".
> > "runnable" will tell if the CPU model can be run in the current
> > host. "unavailable-features" will contain a list of CPU
> > properties that are preventing the CPU model from running in the
> > current host.
> >
> > Cc: David Hildenbrand <address@hidden>
> > Cc: Michael Mueller <address@hidden>
> > Cc: Christian Borntraeger <address@hidden>
> > Cc: Cornelia Huck <address@hidden>
> > Cc: Jiri Denemark <address@hidden>
> > Cc: address@hidden
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
> > qapi-schema.json | 10 +++++++++-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index 54634c4..450e6e7 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -2948,11 +2948,19 @@
> > # Virtual CPU definition.
> > #
> > # @name: the name of the CPU definition
> > +# @runnable: true if the CPU model is runnable using the current
> > +# machine and accelerator. Optional. Since 2.6.
>
> You've missed 2.6. Also, the typical spelling for a per-member
> designation is '(since 2.7)', not 'Since 2.7'
Oops! I meant 2.7, and I didn't notice that it was not using the
typical format. I will fix it, thanks.
>
> Why is it optional? Would it hurt to always be present in qemu new
> enough to understand why it is needed?
It is optional because not all architectures will return the
field. This series implements it only for x86.
--
Eduardo
- Re: [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, (continued)
- Re: [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Markus Armbruster, 2016/05/09
- Re: [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, David Hildenbrand, 2016/05/09
- Re: [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Eduardo Habkost, 2016/05/09
- Re: [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, David Hildenbrand, 2016/05/09
- Re: [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Eduardo Habkost, 2016/05/09
- Re: [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, David Hildenbrand, 2016/05/09
- Re: [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Eduardo Habkost, 2016/05/09
- Re: [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, David Hildenbrand, 2016/05/10
- Re: [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Eduardo Habkost, 2016/05/10
Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Eric Blake, 2016/05/09
- Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions,
Eduardo Habkost <=
- Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Markus Armbruster, 2016/05/10
- Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Jiri Denemark, 2016/05/10
- Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Eduardo Habkost, 2016/05/10
- Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Markus Armbruster, 2016/05/11
- Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Eduardo Habkost, 2016/05/11
- Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, David Hildenbrand, 2016/05/12
- Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Jiri Denemark, 2016/05/12
- Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Eduardo Habkost, 2016/05/12
Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Markus Armbruster, 2016/05/12
Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Eduardo Habkost, 2016/05/27