Re: [Qemu-devel] [PATCH for-2.7 v3 00/12] vl: graphics stubs + #ifdef cleanup + DT_NOGRAPHIC cleanup

[Paolo Bonzini]

On 19/04/2016 21:55, Eduardo Habkost wrote:
> * Clean up the graphics initialization code to reduce the
>   number of #ifdefs;
> * Remove the display_type == DT_NOGRAPHIC checks from hardware
>   emulation code;
> * Make the display_type global variable a local variable on
>   main();
> * Make the display_remote static variable a local variable on
>   main().
> 
> Changes v2 -> v3:
> * Include the DT_NOGRAPHIC patches again in the series, so all of
>   them can be reviewed
> * Move the stub code to inline functions at console.h.
>   This was done to simplify the series, as build dependencies get
>   tricky when trying to build libqemustub.a with --disable-user
>   --disable-system (it disables pixman build flags, and console.h
>   won't build because qemu-pixman.h requires pixman headers)
> * Now the series is based on my 'machine-next' branch, available
>   at:
>   https://github.com/ehabkost/qemu.git machine-next
> 
> Changes v1 -> v2:
> * Patches 2-6: Move stub files to stubs/ui/
> * Patch 7: Move stubs to qemu-spice.h, as the header file
>   already had a separate section for !CONFIG_SPICE
> * Removed DT_NOGRAPHIC patches from the series (they will be sent
>   as a separate series)
> 
> Eduardo Habkost (12):
>   vl: Add DT_COCOA DisplayType value
>   vnc: Initialization stubs
>   curses: curses_display_init() stub
>   sdl: Initialization stubs
>   cocoa: cocoa_display_init() stub
>   gtk: Initialization stubs
>   spice: Initialization stubs on qemu-spice.h
>   milkymist: Move DT_NOGRAPHIC check outside milkymist_tmu2_create()
>   vl: Replace DT_NOGRAPHIC with machine option
>   vl: Make display_type a local variable
>   vl: Move DisplayType typedef to vl.c
>   vl: Make display_remote a local variable
> 
>  hw/core/machine.c       | 21 +++++++++++++++
>  hw/lm32/milkymist-hw.h  |  4 ---
>  hw/lm32/milkymist.c     |  4 ++-
>  hw/nvram/fw_cfg.c       |  6 +++--
>  hw/sparc/sun4m.c        |  2 +-
>  include/hw/boards.h     |  1 +
>  include/sysemu/sysemu.h | 11 --------
>  include/ui/console.h    | 71 
> ++++++++++++++++++++++++++++++++++++++++++++++++-
>  include/ui/qemu-spice.h | 13 +++++++++
>  vl.c                    | 66 +++++++++++++++++----------------------------
>  10 files changed, 138 insertions(+), 61 deletions(-)

Very nice, I suppose you'll be sending the pull request?

Paolo