Re: [Qemu-devel] [PATCH 1/5] cpu-exec: Move halt handling out of cpu_exec()

[Richard Henderson]

On 05/10/2016 05:46 AM, Sergey Fedorov wrote:
> +#if defined(TARGET_I386) && !defined(CONFIG_USER_ONLY)
> +        X86CPU *x86_cpu = X86_CPU(cpu);
> +
> +        if ((cpu->interrupt_request & CPU_INTERRUPT_POLL)
> +            && replay_interrupt()) {
> +            apic_poll_irq(x86_cpu->apic_state);

Since you're moving this around, you might as well place the x86_cpu variable 
in the inner-most if, next to its only use.

Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~