Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code

[Christian Borntraeger]

On 05/09/2016 07:57 PM, Peter Maydell wrote:
> On 9 May 2016 at 18:55, Peter Maydell <address@hidden> wrote:
>> On 9 May 2016 at 18:53, Stefan Weil <address@hidden> wrote:
>>> I suggest to apply this patch to 2.6, if this is still possible
>>
>> It is not; sorry.

I think we have delayed 2.6 already far too long (so please release)
but


> Note that it's only an error if you're building with -Werror, and
> releases don't default to -Werror, so users using released QEMU 2.6
> shouldn't hit this even with the newer gcc. Developers developing
> on trunk shouldn't be unduly inconvenienced if the commit fixing it
> is post-2.6-release rather than the actual release.

to me it looks like that this is not a compile time error, instead we
really do not memset a variable that we are supposed to memset.
the only reason to not consider it for 2.6 is that its is really old
and it did not seem to cause harm.

Christian