[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 09/11] nbd: Add qemu-nbd -D for human-readabl
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v4 09/11] nbd: Add qemu-nbd -D for human-readable description |
Date: |
Thu, 12 May 2016 08:47:30 +0100 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On Wed, May 11, 2016 at 04:39:42PM -0600, Eric Blake wrote:
> The NBD protocol allows servers to advertise a human-readable
> description alongside an export name during NBD_OPT_LIST. Add
> an option to pass through the user's string to the NBD client.
>
> Doing this also makes it easier to test commit 200650d4, which
> is the client counterpart of receiving the description.
>
> Signed-off-by: Eric Blake <address@hidden>
> ---
> include/block/nbd.h | 1 +
> nbd/nbd-internal.h | 5 +++--
> nbd/server.c | 34 ++++++++++++++++++++++++++--------
> qemu-nbd.c | 12 +++++++++++-
> qemu-nbd.texi | 5 ++++-
> 5 files changed, 45 insertions(+), 12 deletions(-)
> diff --git a/qemu-nbd.texi b/qemu-nbd.texi
> index 9f23343..923de74 100644
> --- a/qemu-nbd.texi
> +++ b/qemu-nbd.texi
> @@ -79,9 +79,12 @@ Disconnect the device @var{dev}
> Allow up to @var{num} clients to share the device (default @samp{1})
> @item -t, --persistent
> Don't exit on the last connection
> address@hidden -x NAME, --export-name=NAME
> address@hidden -x, address@hidden
Why this change - that reads as saying that '-x' doesn't take any value
which is wrong IMHO
> Set the NBD volume export name. This switches the server to use
> the new style NBD protocol negotiation
> address@hidden -D, address@hidden
Likewise this suggests -D doesn't take a value
> +Set the NBD volume export description, as a human-readable
> +string. Requires the use of @option{-x}
> @item --tls-creds=ID
> Enable mandatory TLS encryption for the server by setting the ID
> of the TLS credentials object previously created with the --object
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH v4 00/11] nbd: tighter protocol compliance, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 01/11] nbd: Use BDRV_REQ_FUA for better FUA where supported, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 10/11] nbd: Detect servers that send unexpected error values, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 11/11] nbd: Avoid magic number for NBD max name size, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 07/11] nbd: Clean up ioctl handling of qemu-nbd -c, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 06/11] nbd: Group all Linux-specific ioctl code in one place, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 02/11] nbd: More debug typo fixes, use correct formats, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 05/11] nbd: Reject unknown request flags, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 08/11] nbd: Limit nbdflags to 16 bits, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 09/11] nbd: Add qemu-nbd -D for human-readable description, Eric Blake, 2016/05/11
- Re: [Qemu-devel] [PATCH v4 09/11] nbd: Add qemu-nbd -D for human-readable description,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH v4 03/11] nbd: Quit server after any write error, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 04/11] nbd: Improve server handling of bogus commands, Eric Blake, 2016/05/11
- Re: [Qemu-devel] [PATCH v4 00/11] nbd: tighter protocol compliance, Alex Bligh, 2016/05/12