[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 20/23] tests/string-input-visitor: Add negative integ
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 20/23] tests/string-input-visitor: Add negative integer tests |
Date: |
Thu, 12 May 2016 09:59:07 +0200 |
Add two negative tests, one for int and one for int16List. The latter
exposes a bug: nonsensical input results in an empty list instead of
an error.
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
---
tests/test-string-input-visitor.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/tests/test-string-input-visitor.c
b/tests/test-string-input-visitor.c
index 9e6906a..8114908 100644
--- a/tests/test-string-input-visitor.c
+++ b/tests/test-string-input-visitor.c
@@ -63,6 +63,13 @@ static void test_visitor_in_int(TestInputVisitorData *data,
visit_type_int(v, NULL, &res, &err);
g_assert(!err);
g_assert_cmpint(res, ==, value);
+
+ visitor_input_teardown(data, unused);
+
+ v = visitor_input_test_init(data, "not an int");
+
+ visit_type_int(v, NULL, &res, &err);
+ error_free_or_abort(&err);
}
static void test_visitor_in_intList(TestInputVisitorData *data,
@@ -70,6 +77,7 @@ static void test_visitor_in_intList(TestInputVisitorData
*data,
{
int64_t value[] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 20};
int16List *res = NULL, *tmp;
+ Error *err = NULL;
Visitor *v;
int i = 0;
@@ -90,6 +98,13 @@ static void test_visitor_in_intList(TestInputVisitorData
*data,
g_free(tmp);
tmp = res;
}
+
+ visitor_input_teardown(data, unused);
+
+ v = visitor_input_test_init(data, "not an int list");
+
+ visit_type_int16List(v, NULL, &res, &err);
+ /* FIXME fix the visitor, then error_free_or_abort(&err) here */
}
static void test_visitor_in_bool(TestInputVisitorData *data,
--
2.5.5
- [Qemu-devel] [PULL 09/23] qom: Wrap prop visit in visit_start_struct, (continued)
- [Qemu-devel] [PULL 09/23] qom: Wrap prop visit in visit_start_struct, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 10/23] qmp-input: Require struct push to visit members of top dict, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 03/23] qmp: Drop dead command->type, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 01/23] qapi-visit: Add visitor.type classification, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 06/23] qapi: Use strict QMP input visitor in more places, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 07/23] qmp-input: Don't consume input when checking has_member, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 18/23] qmp: Tighten output visitor rules, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 05/23] qapi: Consolidate QMP input visitor creation, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 02/23] qapi: Guarantee NULL obj on input visitor callback error, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 21/23] qapi: Fix string input visitor handling of invalid list, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 20/23] tests/string-input-visitor: Add negative integer tests,
Markus Armbruster <=
- [Qemu-devel] [PULL 14/23] qapi: Add visit_type_null() visitor, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 17/23] qmp: Don't reuse qmp visitor after grabbing output, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 13/23] tests: Add check-qnull, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 23/23] qapi: Change visit_type_FOO() to no longer return partial objects, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 04/23] qmp-input: Clean up stack handling, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 11/23] qmp-input: Refactor when list is advanced, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 16/23] spapr_drc: Expose 'null' in qom-get when there is no fdt, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 22/23] qapi: Simplify semantics of visit_next_list(), Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 08/23] qapi-commands: Wrap argument visit in visit_start_struct, Markus Armbruster, 2016/05/12
- [Qemu-devel] [PULL 15/23] qmp: Support explicit null during visits, Markus Armbruster, 2016/05/12