[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] block: Fix bdrv_next() memory leak
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] block: Fix bdrv_next() memory leak |
|
Date: |
Tue, 24 May 2016 09:14:31 +0800 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Fri, 05/20 19:17, Kevin Wolf wrote:
> The bdrv_next() users all leaked the BdrvNextIterator after completing
> the iteration. Simply changing bdrv_next() to free the iterator before
> returning NULL at the end of list doesn't work because some callers exit
> the loop before looking at all BDSes.
>
> This patch moves the BdrvNextIterator from the heap to the stack of
> the caller and switches to a bdrv_first()/bdrv_next() interface for
> initialising the iterator.
>
> Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>