Re: [Qemu-devel] [PATCH v2 03/28] linux-user: Reindent signal handling

[Riku Voipio]

On tiistaina 24. toukokuuta 2016 3.21.34 EEST, Laurent Vivier wrote:
> Le 12/05/2016 à 19:47, Peter Maydell a écrit :
> > From: Timothy E Baldwin <address@hidden>
> >
> > Some of the signal handling was a mess with a mixture of tabs and 8 space
> > indents.
>
> And adds some braces, but not everywhere.
> [and fails on checkpatch.pl]

Reviewing this for unexpected changes is interesting. Found the most 
reasonable way was to compare the original and patched signal.c after 
passing them with "indent" using arguments roughly resembling qemu 
style[1]. This shows the added braces, which as far as I see don't change 
the logic.

> If we don't add braces everywhere, perhaps it's better to add them nowhere.

I think I will merge this as is, since this would mean fallout in editing 
the patches that come on top of this patch.

> A coccinelle script can help to add them later.
>
> Laurent
>
> > Signed-off-by: Timothy Edward Baldwin <address@hidden>
> > Message-id: 
> > address@hidden
> > Reviewed-by: Peter Maydell <address@hidden>
> > [PMM: just rebased]
> > Signed-off-by: Peter Maydell <address@hidden> ...

[1] indent -nbad -bap -nbc -bbo -hnl -br -brs -c33 -cd33 -ncdb -ce -ci4  
-cli0  -d0 -di1 -nfc1 -i4 -ip0 -l80 -lp -npcs -nprs -npsl -sai -saf -saw 
-ncs -nsc -sob -nfca -cp33 -ss -ts4 -il1 -nut # kernel style changed to 4 
spaces