Re: [Qemu-devel] [PATCH v5 5/6] acpi: Add IPMI table entries

[Igor Mammedov]

On Mon, 23 May 2016 20:06:57 +0200
Paolo Bonzini <address@hidden> wrote:

> On 20/05/2016 11:53, Igor Mammedov wrote:
> >> > diff --git a/hw/acpi/noipmi.c b/hw/acpi/noipmi.c
> >> > new file mode 100644
> >> > index 0000000..dd7590d
> >> > --- /dev/null
> >> > +++ b/hw/acpi/noipmi.c  
> > move this to .a/stubs/
> >   
> 
> Don't overuse stubs.  The stubs library is mostly to share code between
> QEMU and the tools.  What Corey did is more similar to what hw/ already
> does in other places.
So what's the rule when one should use stubs or not?

> 
> Unfortunately, weak symbols are not portable. :(
> 
> Paolo