[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 02/27] qapi: Add lock-mode in blockdev-add op
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v5 02/27] qapi: Add lock-mode in blockdev-add options |
Date: |
Tue, 24 May 2016 14:15:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 17.05.2016 09:35, Fam Zheng wrote:
> To allow overriding the default locking behavior when opening the image.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> qapi/block-core.json | 20 +++++++++++++++++++-
> 1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 98a20d2..3c54f64 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2032,6 +2032,21 @@
> '*read-pattern': 'QuorumReadPattern' } }
>
> ##
> +# @BlockdevLockMode
> +#
> +# Describes the operation mode for the automatic conversion of plain
> +# zero writes by the OS to driver specific optimized zero write commands.
I don't think so. ;-)
Max
> +#
> +# @off: Disabled
> +# @shared: Use shared lock for both RO and RW images.
> +# @exclusive: Use exclusive lock for RW images, and shared lock for RO
> images.
> +#
> +# Since: 2.7
> +##
> +{ 'enum': 'BlockdevLockMode',
> + 'data': [ 'off', 'shared', 'exclusive' ] }
> +
> +##
> # @BlockdevOptions
> #
> # Options for creating a block device. Many options are available for all
> @@ -2065,6 +2080,8 @@
> # @detect-zeroes: #optional detect and optimize zero writes (Since 2.1)
> # (default: off)
> #
> +# @lock-mode: #optional how to lock the image. (default: exclusive) (Since
> 2.7)
> +#
> # Remaining options are determined by the block driver.
> #
> # Since: 1.7
> @@ -2082,7 +2099,8 @@
> '*stats-account-invalid': 'bool',
> '*stats-account-failed': 'bool',
> '*stats-intervals': ['int'],
> - '*detect-zeroes': 'BlockdevDetectZeroesOptions' },
> + '*detect-zeroes': 'BlockdevDetectZeroesOptions',
> + '*lock-mode': 'BlockdevLockMode' },
> 'discriminator': 'driver',
> 'data': {
> 'archipelago':'BlockdevOptionsArchipelago',
>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v5 00/27] block: Lock images when opening, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 01/27] block: Add flag bits for image locking, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 03/27] blockdev: Add and parse "lock-mode" option for image locking, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 02/27] qapi: Add lock-mode in blockdev-add options, Fam Zheng, 2016/05/17
- Re: [Qemu-devel] [PATCH v5 02/27] qapi: Add lock-mode in blockdev-add options,
Max Reitz <=
- [Qemu-devel] [PATCH v5 04/27] block: Introduce image file locking, Fam Zheng, 2016/05/17
- [Qemu-devel] [PATCH v5 07/27] block: Handle image locking during reopen, Fam Zheng, 2016/05/17
[Qemu-devel] [PATCH v5 05/27] block: Add bdrv_image_locked, Fam Zheng, 2016/05/17
[Qemu-devel] [PATCH v5 06/27] block: Make bdrv_reopen_{commit, abort} private functions, Fam Zheng, 2016/05/17