[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/3] scsi: megasas: initialise local configuration d
|
From: |
P J P |
|
Subject: |
[Qemu-devel] [PATCH 2/3] scsi: megasas: initialise local configuration data buffer |
|
Date: |
Wed, 25 May 2016 16:01:30 +0530 |
From: Prasad J Pandit <address@hidden>
When reading MegaRAID SAS controller configuration via MegaRAID
Firmware Interface(MFI) commands, routine megasas_dcmd_cfg_read
uses an uninitialised local data buffer. Initialise this buffer
to avoid stack information leakage.
Reported-by: Li Qiang <address@hidden>
Signed-off-by: Prasad J Pandit <address@hidden>
---
hw/scsi/megasas.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
index dcbd3e1..7c08932 100644
--- a/hw/scsi/megasas.c
+++ b/hw/scsi/megasas.c
@@ -1305,6 +1305,7 @@ static int megasas_dcmd_cfg_read(MegasasState *s,
MegasasCmd *cmd)
QTAILQ_FOREACH(kid, &s->bus.qbus.children, sibling) {
num_pd_disks++;
}
+ memset(data, 0, sizeof(data));
info = (struct mfi_config_data *)&data;
/*
* Array mapping:
--
2.5.5
[Qemu-devel] [PATCH 2/3] scsi: megasas: initialise local configuration data buffer,
P J P <=
[Qemu-devel] [PATCH 3/3] scsi: megasas: check 'read_queue_head' index value, P J P, 2016/05/25
Re: [Qemu-devel] [PATCH 0/3] Qemu: scsi: megasas: various OOB r/w access checks, Paolo Bonzini, 2016/05/25