[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/14] block: Default to enabled write cache
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/14] block: Default to enabled write cache in blk_new() |
Date: |
Wed, 25 May 2016 13:32:05 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 24 May 2016 03:47:23 PM CEST, Kevin Wolf wrote:
> The existing users of the function are:
>
> 1. blk_new_open(), which already enabled the write cache
> 2. Some test cases that don't care about the setting
> 3. blockdev_init() for empty drives, where the cache mode is overridden
> with the value from the options when a medium is inserted
>
> Therefore, this patch doesn't change the current behaviour. It will be
> convenient, however, for additional users of blk_new() (like block
> jobs) if the most sensible WCE setting is the default.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Berto
- [Qemu-devel] [PATCH v2 00/14] block jobs: Convert I/O to BlockBackend, Kevin Wolf, 2016/05/24
- [Qemu-devel] [PATCH v2 03/14] block: Default to enabled write cache in blk_new(), Kevin Wolf, 2016/05/24
- Re: [Qemu-devel] [PATCH v2 03/14] block: Default to enabled write cache in blk_new(),
Alberto Garcia <=
- [Qemu-devel] [PATCH v2 02/14] block: Cancel jobs first in bdrv_close_all(), Kevin Wolf, 2016/05/24
- [Qemu-devel] [PATCH v2 01/14] block: keep a list of block jobs, Kevin Wolf, 2016/05/24
- [Qemu-devel] [PATCH v2 04/14] block: Convert block job core to BlockBackend, Kevin Wolf, 2016/05/24
- [Qemu-devel] [PATCH v2 09/14] backup: Don't leak BackupBlockJob in error path, Kevin Wolf, 2016/05/24
- [Qemu-devel] [PATCH v2 10/14] backup: Pack Notifier within BackupBlockJob, Kevin Wolf, 2016/05/24