[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 1/3] loader: Allow ELF loader to auto-detect
From: |
Alistair Francis |
Subject: |
Re: [Qemu-devel] [PATCH v6 1/3] loader: Allow ELF loader to auto-detect the ELF arch |
Date: |
Wed, 25 May 2016 11:22:04 -0700 |
On Tue, May 24, 2016 at 3:08 PM, Cleber Rosa <address@hidden> wrote:
>
> On 05/13/2016 05:37 PM, Alistair Francis wrote:
>>
>>
>> + if (elf_machine < 1) {
>> + /* The caller didn't specify and ARCH, we can figure it out */
>
>
> Spotted a comment typo: s/and/an/
Thanks, sending a version 7 with it fixed.
Thanks,
Alistair
>
>
>> + lseek(fd, 0x12, SEEK_SET);
>> + if (read(fd, &e_machine, sizeof(e_machine)) != sizeof(e_machine))
>> {
>> + goto fail;
>> + }
>> + elf_machine = e_machine;
>> + }
>> +
>
>
> --
> Cleber Rosa
> [ Sr Software Engineer - Virtualization Team - Red Hat ]
> [ Avocado Test Framework - avocado-framework.github.io ]
>