[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests |
Date: |
Thu, 26 May 2016 09:55:10 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
On 26/05/2016 09:10, Fam Zheng wrote:
>
> diff --git a/block/io.c b/block/io.c
> index d480097..a6523cf 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -1435,8 +1435,10 @@ int coroutine_fn bdrv_co_pwritev(BlockDriverState *bs,
> * than one aligned block.
> */
> if (bytes < align) {
> + bdrv_debug_event(bs, BLKDBG_PWRITEV_RMW_TAIL);
> qemu_iovec_add(&local_qiov, head_buf + bytes, align - bytes);
> bytes = align;
> + bdrv_debug_event(bs, BLKDBG_PWRITEV_RMW_AFTER_TAIL);
> }
> }
This doesn't look too wrong... Should the right sequence of events be
head/after_head or head/after_tail? It's probably simplest to just emit
all four events.
Paolo
- [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests, Peter Lieven, 2016/05/24
- Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests, Kevin Wolf, 2016/05/24
- Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests, Fam Zheng, 2016/05/26
- Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests, Fam Zheng, 2016/05/26
- Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests, Fam Zheng, 2016/05/26
- Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests, Paolo Bonzini, 2016/05/26
- Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests, Fam Zheng, 2016/05/26
- Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests, Kevin Wolf, 2016/05/27
- Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests, Peter Lieven, 2016/05/30
- Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests, Kevin Wolf, 2016/05/30
- Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests, Peter Lieven, 2016/05/30
- Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests, Kevin Wolf, 2016/05/30
- Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests, Peter Lieven, 2016/05/30
- Re: [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests, Kevin Wolf, 2016/05/30