Re: [Qemu-devel] [for-2.7 PATCH v3 01/15] exec: Remove cpu from cpus list during cpu_exec_exit()

[David Gibson]

On Thu, May 26, 2016 at 12:12:41PM +0200, Paolo Bonzini wrote:
> 
> 
> On 12/05/2016 05:48, Bharata B Rao wrote:
> > CPUState *cpu gets added to the cpus list during cpu_exec_init(). It
> > should be removed from cpu_exec_exit().
> > 
> > cpu_exec_exit() is called from generic CPU::instance_finalize and some
> > archs like PowerPC call it from CPU unrealizefn. So ensure that we
> > dequeue the cpu only once.
> 
> I think the better thing would be to call it from CPU::unrealize, but
> this patch is okay too.
> 
> Thanks,
> 
> Paolo

Thanks for the review Paolo.

However, what I'm really unclear on is what is the next step towards
merging these.  Will you take them through your tree?  Should Bharata
send a formal pull request with the prelim patches?  If so, to whom?

> > Now -1 value for cpu->cpu_index indicates that we have already dequeued
> > the cpu for CONFIG_USER_ONLY case also.
> > 
> > Signed-off-by: Bharata B Rao <address@hidden>
> > Reviewed-by: David Gibson <address@hidden>
> > Reviewed-by: Thomas Huth <address@hidden>
> 

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature