Re: [Qemu-devel] including the "git describe" output in the QEMU binaries?

[Laszlo Ersek]

On 05/31/16 15:19, Daniel P. Berrange wrote:
> On Tue, May 31, 2016 at 12:32:48PM +0100, Daniel P. Berrange wrote:
>> On Tue, May 31, 2016 at 01:16:14PM +0200, Laszlo Ersek wrote:
>>> Hi,
>>>
>>> has this been raised / considered before? To me at least it would be
>>> extremely useful if QEMU binaries built from a git working directory
>>> returned the output of "git describe" (+ possibly a hint about an
>>> unclean working directory), when invoked with "-version".
>>>
>>> Not volunteering for the implementation, and also not suggesting /
>>> requesting that others implement it (everyone is busy with real stuff,
>>> I'm sure); just asking if it's been considered.
>>
>> Currently configure supports a --pkgversion flag which is used by people
>> packaging QEMU in RPM/Debs to include their arbitrary custom version string.
>> This information is then reported by -version and the appropriate QMP
>> command.
>>
>> We could quite easily make configure default the pkgversion to the current
>> GIT hash if --pkgversion is not explicitly given.
> 
> Oh and the nice thing about this is that it is plumbed into libvirt, so
> whenever libvirt starts a guest, it will log the pkgversion associated
> with QEMU to /var/log/libvirt/qemu/$GUEST.log

Awesome. I use all my long-term guests (that I keep flipping between
upstream and downstream QEMU) with libvirt. Associating log sections
with git trees would be great.

Let's see if I can write this patch in no more than five iterations...

Laszlo