[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/10] target-i386: print obsolete warnings if +
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used |
Date: |
Tue, 7 Jun 2016 13:44:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 06/06/2016 17:16, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> target-i386/cpu.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index f791a06..31e5e6f 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1975,6 +1975,9 @@ static void x86_cpu_parse_featurestr(CPUState *cs, char
> *features,
> error_propagate(errp, local_err);
> return;
> }
> + fprintf(stderr,
> + "'+%s' is obsolete and will be removed in future, use
> '%s=on'",
> + featurestr + 1, featurestr + 1);
Could you detect using +foo together with foo=off, and -foo together
with foo=on? Those are the really problematic cases, without them +foo
and -foo can become synonyms for =on and =off.
Paolo
> continue;
> } else if (featurestr[0] == '-') {
> add_flagname_to_bitmaps(featurestr + 1, minus_features,
> &local_err);
> @@ -1982,6 +1985,9 @@ static void x86_cpu_parse_featurestr(CPUState *cs, char
> *features,
> error_propagate(errp, local_err);
> return;
> }
> + fprintf(stderr,
> + "'-%s' is obsolete and will be removed in future, use
> '%s=off'",
> + featurestr + 1, featurestr + 1);
> continue;
> }
>
>
- [Qemu-devel] [PATCH 00/10] cpus: make "-cpu cpux, features" global properties, Igor Mammedov, 2016/06/06
- [Qemu-devel] [PATCH 03/10] target-i386: cpu: move xcc->kvm_required check to realize time, Igor Mammedov, 2016/06/06
- [Qemu-devel] [PATCH 01/10] target-i386: Remove xlevel & hv-spinlocks option fixups, Igor Mammedov, 2016/06/06
- [Qemu-devel] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used, Igor Mammedov, 2016/06/06
- Re: [Qemu-devel] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used, Igor Mammedov, 2016/06/07
- Re: [Qemu-devel] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used, Paolo Bonzini, 2016/06/07
- Re: [Qemu-devel] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used, Igor Mammedov, 2016/06/07
- Re: [Qemu-devel] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used, Paolo Bonzini, 2016/06/07
- Re: [Qemu-devel] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used, Igor Mammedov, 2016/06/07
- Re: [Qemu-devel] [PATCH 06/10] target-i386: print obsolete warnings if +-features are used, Eduardo Habkost, 2016/06/07
[Qemu-devel] [PATCH 04/10] target-i386: cpu: use cpu_generic_init() in cpu_x86_init(), Igor Mammedov, 2016/06/06
[Qemu-devel] [PATCH 10/10] pc: parse cpu features only once, Igor Mammedov, 2016/06/06