[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/15] tb hash improvements
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PULL 00/15] tb hash improvements |
Date: |
Fri, 10 Jun 2016 15:24:12 -0400 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Jun 10, 2016 at 17:41:26 +0100, Peter Maydell wrote:
> On 10 June 2016 at 17:34, Emilio G. Cota <address@hidden> wrote:
> > On Fri, Jun 10, 2016 at 16:33:10 +0100, Peter Maydell wrote:
> >> Fails to build on ppc64be :-(
> >>
> >> In file included from /home/pm215/qemu/include/qemu/thread.h:4:0,
> >> from /home/pm215/qemu/include/block/aio.h:20,
> >> from /home/pm215/qemu/include/block/block.h:4,
> >> from /home/pm215/qemu/include/monitor/monitor.h:6,
> >> from /home/pm215/qemu/trace/control.c:23:
> >> /home/pm215/qemu/include/qemu/processor.h:24:35: error: expected
> >> identifier or ‘(’ before string constant
> >> "or 2, 2, 2;" ::: "memory")
> >
> > On Fri, Jun 10, 2016 at 16:57:19 +0100, Peter Maydell wrote:
> >> Also fails trying to build a test on 32-bit:
> >>
> >> /home/petmay01/qemu/tests/qht-bench.c: In function 'pr_params':
> >> /home/petmay01/qemu/tests/qht-bench.c:270:5: error: format '%zu'
> >> expects argument of type 'size_t', but argument 2 has type 'long
> >> unsigned int' [-Werror=format=]
> >> printf(" lookup range: %zu\n", lookup_range);
> >
> > Can you please test again after applying the appended delta?
>
> I will test.
>
> For the PPC asm, is it not just wanting the "\n" between instructions?
> Shouldn't be necessary to use two separate asm() lines...
I can't test on ppc so I was just being paranoid to avoid
wasting your time :-)
E.
- [Qemu-devel] [PULL 12/15] qht: add qht-bench, a performance benchmark, (continued)
- [Qemu-devel] [PULL 12/15] qht: add qht-bench, a performance benchmark, Richard Henderson, 2016/06/10
- [Qemu-devel] [PULL 15/15] translate-all: add tb hash bucket info to 'info jit' dump, Richard Henderson, 2016/06/10
- [Qemu-devel] [PULL 14/15] tb hash: track translated blocks with qht, Richard Henderson, 2016/06/10
- [Qemu-devel] [PULL 08/15] qdist: add module to represent frequency distributions of data, Richard Henderson, 2016/06/10
- [Qemu-devel] [PULL 11/15] qht: add test program, Richard Henderson, 2016/06/10
- [Qemu-devel] [PULL 10/15] qht: QEMU's fast, resizable and scalable Hash Table, Richard Henderson, 2016/06/10
- Re: [Qemu-devel] [PULL 00/15] tb hash improvements, Peter Maydell, 2016/06/10