[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vl: Error messages need to go to stderr, fix so
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] vl: Error messages need to go to stderr, fix some |
Date: |
Mon, 13 Jun 2016 11:03:14 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Paolo, will you pick this up, or do you want me to take it through my
(currently empty) error-next branch?
Markus Armbruster <address@hidden> writes:
> We print a few fatal error messages to stdout instead of stderr.
> Reproducer:
>
> $ qemu-system-x86_64 -g 1024x768
> Option g not supported for this target
> $ qemu-system-x86_64 -g 1024x768 >/dev/null
>
> Fix by printing them with error_report(). This also improves the messages.
> The above one becomes
>
> qemu-system-x86_64: -g 1024x768: Option not supported for this target
>
> Reported-by: Tobi {github.com/tobimensch}
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> vl.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 18d1423..7800b31 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3075,7 +3075,7 @@ int main(int argc, char **argv, char **envp)
>
> popt = lookup_opt(argc, argv, &optarg, &optind);
> if (!(popt->arch_mask & arch_type)) {
> - printf("Option %s not supported for this target\n",
> popt->name);
> + error_report("Option not supported for this target");
> exit(1);
> }
> switch(popt->index) {
> @@ -3849,21 +3849,21 @@ int main(int argc, char **argv, char **envp)
> break;
> case QEMU_OPTION_xen_domid:
> if (!(xen_available())) {
> - printf("Option %s not supported for this target\n",
> popt->name);
> + error_report("Option not supported for this target");
> exit(1);
> }
> xen_domid = atoi(optarg);
> break;
> case QEMU_OPTION_xen_create:
> if (!(xen_available())) {
> - printf("Option %s not supported for this target\n",
> popt->name);
> + error_report("Option not supported for this target");
> exit(1);
> }
> xen_mode = XEN_CREATE;
> break;
> case QEMU_OPTION_xen_attach:
> if (!(xen_available())) {
> - printf("Option %s not supported for this target\n",
> popt->name);
> + error_report("Option not supported for this target");
> exit(1);
> }
> xen_mode = XEN_ATTACH;
- Re: [Qemu-devel] [PATCH] vl: Error messages need to go to stderr, fix some,
Markus Armbruster <=