[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2 3/3] Remove unnecessary variables for function
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [RFC v2 3/3] Remove unnecessary variables for function return value |
Date: |
Mon, 13 Jun 2016 13:29:47 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eduardo Habkost <address@hidden> writes:
> Use Coccinelle script to replace 'ret = E; return ret' with
> 'return E'. The script will do the substitution only when the
> function return type and variable type are the same.
>
> Sending as RFC because the patch looks more intrusive than the
> others. Probably better to split it per subsystem and let each
> maintainer review and apply it?
As far as I'm concerned, obvious mechanical cleanups like this one can
go in as a single tree-wide patch. I'd consider making you split it up,
then chase maintainers a waste of your time[*].
checkpatch.pl is unhappy:
529: WARNING: line over 80 characters
563: WARNING: line over 80 characters
695: WARNING: line over 80 characters
811: ERROR: return is not a function, parentheses are not required
830: ERROR: return is not a function, parentheses are not required
849: ERROR: return is not a function, parentheses are not required
[*] Been there, done that, but if it is what it takes...
- Re: [Qemu-devel] [PATCH v2 2/3] error: Remove unnecessary local_err variables, (continued)
- Re: [Qemu-devel] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Cornelia Huck, 2016/06/13
- Re: [Qemu-devel] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Markus Armbruster, 2016/06/13
- Re: [Qemu-devel] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Eduardo Habkost, 2016/06/13
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Eric Blake, 2016/06/13
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Markus Armbruster, 2016/06/13
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Eduardo Habkost, 2016/06/13
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Markus Armbruster, 2016/06/14
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 2/3] error: Remove unnecessary local_err variables, Eduardo Habkost, 2016/06/13
[Qemu-devel] [RFC v2 3/3] Remove unnecessary variables for function return value, Eduardo Habkost, 2016/06/10