[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/4] linux-user: pass environment arguments i
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/4] linux-user: pass environment arguments in execve |
Date: |
Wed, 15 Jun 2016 21:59:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
Le 14/06/2016 à 21:26, Joel Holdsworth a écrit :
> Previously, when emulating execve(2), qemu would execute a child
> instance of the emulator with the environment variables provided by
> the parent process. This caused problems with qemu if any of the
> variables affected the child emulator's behaviour e.g.
> LD_LIBRARY_PATH.
The best way to avoid that is to use a statically linked qemu.
> This patch solves this issue by passing the environment variables
> with '-E' arguments to the child qemu instance. The call to
> execve(2) is replaced by a call to execv(2) so that the parent
> emulator's environment variable state is propagated into the child.
>
> Any variables from the host environment that are not in the in the
> execve() call are removed with a '-U' argument.
Run ./scripts/checkpatch.pl on your patch...
and add your Signed-off-by here.
The environment is already managed in linux-user/main.c:main(), I don't
understand why the qemu_execve() special case should differ from the
general case.
Thanks,
Laurent
- [Qemu-devel] [PATCH v2 1/4] linux-user: add option to intercept execve() syscalls, (continued)
- [Qemu-devel] [PATCH v2 1/4] linux-user: add option to intercept execve() syscalls, Joel Holdsworth, 2016/06/14
- [Qemu-devel] [PATCH v2 4/4] linux-user: pass strace argument in execve, Joel Holdsworth, 2016/06/14
- [Qemu-devel] [PATCH v2 3/4] linux-user: pass elf interpreter prefix in execve, Joel Holdsworth, 2016/06/14
- [Qemu-devel] [PATCH v2 2/4] linux-user: pass environment arguments in execve, Joel Holdsworth, 2016/06/14
- Re: [Qemu-devel] [PATCH v2 2/4] linux-user: pass environment arguments in execve,
Laurent Vivier <=
- Re: [Qemu-devel] [PATCH v2 2/4] linux-user: pass environment arguments in execve, Joel Holdsworth, 2016/06/20
- Re: [Qemu-devel] [PATCH v2 2/4] linux-user: pass environment arguments in execve, Laurent Vivier, 2016/06/20
- Re: [Qemu-devel] [PATCH v2 2/4] linux-user: pass environment arguments in execve, Joel Holdsworth, 2016/06/20
- Re: [Qemu-devel] [PATCH v2 2/4] linux-user: pass environment arguments in execve, Peter Maydell, 2016/06/20
- Re: [Qemu-devel] [PATCH v2 2/4] linux-user: pass environment arguments in execve, Joel Holdsworth, 2016/06/20
- Re: [Qemu-devel] [PATCH v2 2/4] linux-user: pass environment arguments in execve, Peter Maydell, 2016/06/20