[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 16/17] block: Split bdrv_merge_limits() from
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2 16/17] block: Split bdrv_merge_limits() from bdrv_refresh_limits() |
Date: |
Thu, 16 Jun 2016 13:50:00 +0800 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Tue, 06/14 15:30, Eric Blake wrote:
> The raw block driver was blindly copying all limits from bs->file,
> even though: 1. the main bdrv_refresh_limits() already does this
> for many of gthe limits, and 2. blindly copying from the children
s/gthe/the ?
> can weaken any stricter limits that were already inherited from
> the backing dhain during the main bdrv_refresh_limits(). Also,
> the next patch is about to move .request_alignment into
> BlockLimits, and that is a limit that should NOT be copied from
> other layers in the BDS chain.
>
> Solve the issue by factoring out a new bdrv_merge_limits(),
> and using that function to properly merge limits when comparing
> two BlockDriverState objects.
>
> Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
- Re: [Qemu-devel] [PATCH v2 17/17] block: Move request_alignment into BlockLimit, (continued)
[Qemu-devel] [PATCH v2 14/17] block: Switch transfer length bounds to byte-based, Eric Blake, 2016/06/14
[Qemu-devel] [PATCH v2 09/17] iscsi: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/14
[Qemu-devel] [PATCH v2 16/17] block: Split bdrv_merge_limits() from bdrv_refresh_limits(), Eric Blake, 2016/06/14
[Qemu-devel] [PATCH v2 08/17] blkdebug: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/14
Re: [Qemu-devel] [PATCH v2 00/17] Byte-based block limits, Kevin Wolf, 2016/06/21