Re: [Qemu-devel] [PULL 00/30] KVM, build, NBD, SCSI patches for 2016-06-16

[Peter Maydell]

On 16 June 2016 at 15:15, Paolo Bonzini <address@hidden> wrote:
> The following changes since commit da2fdd0bd1514a44309dd5be162ebfb6c166a716:
>
>   Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20160611' into 
> staging (2016-06-13 10:12:44 +0100)
>
> are available in the git repository at:
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 2ab9b0ec185124607ff71ee4048e927016fad26d:
>
>   vl: smp_parse: cleanups (2016-06-16 14:35:20 +0200)
>
> ----------------------------------------------------------------
> * KVM startup speedup (Chao Peng)
> * configure fixes and cleanups (David, Thomas)
> * ctags fix (Sergey)
> * NBD cleanups (Peter, Eric)
> * "-L help" command line option (Richard)
> * More esp.c bugfixes (me, Prasad)
> * KVM_CAP_MAX_VCPU_ID support (Greg)

Hi. I'm afraid this generates format string warnings on OSX:

/Users/pm215/src/qemu-for-merges/nbd/server.c:580:34: warning: format
specifies type 'unsigned short' but the argument has type 'unsigned
int' [-Wformat]
              client->exp->size, client->exp->nbdflags | myflags);
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/pm215/src/qemu-for-merges/nbd/nbd-internal.h:44:21: note:
expanded from macro 'TRACE'
        LOG(msg, ## __VA_ARGS__); \
                    ^
/Users/pm215/src/qemu-for-merges/nbd/nbd-internal.h:50:50: note:
expanded from macro 'LOG'
            __FILE__, __FUNCTION__, __LINE__, ## __VA_ARGS__); \
                                                 ^
/Users/pm215/src/qemu-for-merges/nbd/server.c:611:34: warning: format
specifies type 'unsigned short' but the argument has type 'unsigned
int' [-Wformat]
              client->exp->size, client->exp->nbdflags | myflags);
                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/pm215/src/qemu-for-merges/nbd/nbd-internal.h:44:21: note:
expanded from macro 'TRACE'
        LOG(msg, ## __VA_ARGS__); \
                    ^
/Users/pm215/src/qemu-for-merges/nbd/nbd-internal.h:50:50: note:
expanded from macro 'LOG'
            __FILE__, __FUNCTION__, __LINE__, ## __VA_ARGS__); \
                                                 ^
  CC    nbd/client.o
  CC    nbd/common.o
  CC    block/curl.o
/Users/pm215/src/qemu-for-merges/nbd/client.c:715:57: warning: format
specifies type 'unsigned short' but the argument has type 'uint32_t'
(aka 'unsigned int') [-Wformat]
          request->from, request->len, request->handle, request->type);
                                                        ^~~~~~~~~~~~~
/Users/pm215/src/qemu-for-merges/nbd/nbd-internal.h:44:21: note:
expanded from macro 'TRACE'
        LOG(msg, ## __VA_ARGS__); \
                    ^
/Users/pm215/src/qemu-for-merges/nbd/nbd-internal.h:50:50: note:
expanded from macro 'LOG'
            __FILE__, __FUNCTION__, __LINE__, ## __VA_ARGS__); \
                                                 ^
2 warnings generated.


thanks
-- PMM