[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] scsi: esp: check length before dma read
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v4] scsi: esp: check length before dma read |
|
Date: |
Fri, 17 Jun 2016 10:26:32 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 17/06/2016 10:16, P J P wrote:
> +-- On Fri, 17 Jun 2016, Amit Shah wrote --+
> | This was flagged as an incompatibility in the vmstate by a nightly run
> | of the vmstate checker:
> |
> | Section "esp" Description "esp" Field "cmdbuf" size mismatch: 16 , 32
> | Section "dc390" Description "esp" Field "cmdbuf" size mismatch: 16 , 32
> | Section "am53c974" Description "esp" Field "cmdbuf" size mismatch: 16 , 32
>
> Probably vmstate file needs to be regenerated?
No, that's not what that means. It means that your patch broke
migration compatibility. I've posted a patch to just remove the code
(which also has the effect of reverting your patch and mine).
Paolo