[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v1 2/4] exec.c: Remove static allocation of
From: |
Vijay Kilari |
Subject: |
Re: [Qemu-devel] [RFC PATCH v1 2/4] exec.c: Remove static allocation of sub_section of sub_page |
Date: |
Fri, 17 Jun 2016 15:44:19 +0530 |
Hi Paolo,
On Mon, Jun 13, 2016 at 3:22 PM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 13/06/2016 11:08, address@hidden wrote:
>> From: Vijaya Kumar K <address@hidden>
>>
>> Allocate sub_section dynamically. Remove dependency
>> on TARGET_PAGE_SIZE to make run-time page size detection
>> for arm platforms.
>>
>> Signed-off-by: Vijaya Kumar K <address@hidden>
>> ---
>> exec.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/exec.c b/exec.c
>> index a9d465b..e803a41 100644
>> --- a/exec.c
>> +++ b/exec.c
>> @@ -154,7 +154,7 @@ typedef struct subpage_t {
>> MemoryRegion iomem;
>> AddressSpace *as;
>> hwaddr base;
>> - uint16_t sub_section[TARGET_PAGE_SIZE];
>> + uint16_t *sub_section;
>
> Please make this a flexible array member instead, so that you can avoid
> the extra pointer dereference.
What do you mean by flexible array member?. please give more info.
- [Qemu-devel] [RFC PATCH v1 0/4] ARM/AARCH64: Runtime page size computation, vijayak, 2016/06/13
- [Qemu-devel] [RFC PATCH v1 1/4] migration: Remove static allocation of xzblre cache buffer, vijayak, 2016/06/13
- [Qemu-devel] [RFC PATCH v1 4/4] target-arm: Compute page size based on ARM target cpu type, vijayak, 2016/06/13
- Re: [Qemu-devel] [RFC PATCH v1 4/4] target-arm: Compute page size based on ARM target cpu type, Paolo Bonzini, 2016/06/13
- Re: [Qemu-devel] [RFC PATCH v1 4/4] target-arm: Compute page size based on ARM target cpu type, Peter Maydell, 2016/06/13
- Re: [Qemu-devel] [RFC PATCH v1 4/4] target-arm: Compute page size based on ARM target cpu type, Peter Maydell, 2016/06/13
- Re: [Qemu-devel] [RFC PATCH v1 4/4] target-arm: Compute page size based on ARM target cpu type, Vijay Kilari, 2016/06/14
- Re: [Qemu-devel] [RFC PATCH v1 4/4] target-arm: Compute page size based on ARM target cpu type, Peter Maydell, 2016/06/14
- Re: [Qemu-devel] [RFC PATCH v1 4/4] target-arm: Compute page size based on ARM target cpu type, Richard Henderson, 2016/06/16
- Re: [Qemu-devel] [RFC PATCH v1 4/4] target-arm: Compute page size based on ARM target cpu type, Vijay Kilari, 2016/06/17