[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] x86: fill high bits of mtrr mask
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] x86: fill high bits of mtrr mask |
Date: |
Fri, 17 Jun 2016 16:19:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 |
On 17/06/2016 15:51, Dr. David Alan Gilbert wrote:
>
>> > Note that the failure mode is pretty brutal since KVM reports an
>> > internal error right after restarting on the destination, and who knows
>> > what used to happen before the assertion was introduced. All MSRs after
>> > MTRRs would be ignored by KVM!
> I think we got lucky because the MTRRs were close to the last MSRs
> in the list, there was only some MCG/MCE stuff after it which probably
> wouldn't have been missed; if the MTRR wasn't set I'm guessing someone
> would have just had a behaviour that looked like dreadful performance
> after migration perhaps?
No, MTRRs are only used by KVM if there's an assigned device, and that's
incompatible with migration.
Paolo
- Re: [Qemu-devel] [PATCH 2/5] x86: Mask mtrr mask based on CPU physical address limits, (continued)
- [Qemu-devel] [PATCH 3/5] x86: fill high bits of mtrr mask, Dr. David Alan Gilbert (git), 2016/06/16
- Re: [Qemu-devel] [PATCH 3/5] x86: fill high bits of mtrr mask, Eduardo Habkost, 2016/06/16
- Re: [Qemu-devel] [PATCH 3/5] x86: fill high bits of mtrr mask, Paolo Bonzini, 2016/06/17
- Re: [Qemu-devel] [PATCH 3/5] x86: fill high bits of mtrr mask, Eduardo Habkost, 2016/06/17
- Re: [Qemu-devel] [PATCH 3/5] x86: fill high bits of mtrr mask, Paolo Bonzini, 2016/06/17
- Re: [Qemu-devel] [PATCH 3/5] x86: fill high bits of mtrr mask, Eduardo Habkost, 2016/06/17
- Re: [Qemu-devel] [PATCH 3/5] x86: fill high bits of mtrr mask, Paolo Bonzini, 2016/06/17
- Re: [Qemu-devel] [PATCH 3/5] x86: fill high bits of mtrr mask, Dr. David Alan Gilbert, 2016/06/17
- Re: [Qemu-devel] [PATCH 3/5] x86: fill high bits of mtrr mask,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 3/5] x86: fill high bits of mtrr mask, Dr. David Alan Gilbert, 2016/06/17
[Qemu-devel] [PATCH 5/5] x86: Set physical address bits based on host, Dr. David Alan Gilbert (git), 2016/06/16
[Qemu-devel] [PATCH 4/5] x86: Allow physical address bits to be set, Dr. David Alan Gilbert (git), 2016/06/16