qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] alpha: Fix build error for linux-user


From: Pranith Kumar
Subject: Re: [Qemu-devel] [PATCH] alpha: Fix build error for linux-user
Date: Fri, 17 Jun 2016 14:07:15 -0400

On Fri, Jun 17, 2016 at 2:04 PM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 16/06/2016 21:07, Richard Henderson wrote:
>>>              && ((addr >> 41) & 3) == 2
>>> -            && addr >> TARGET_VIRT_ADDR_SPACE_BITS == addr >> 63);
>>> +            && addr >> TARGET_VIRT_ADDR_SPACE_BITS == 1);
>
> What you want here is
>
> +               addr >> TARGET_VIRT_ADDR_SPACE_BITS == -1
>
> since that's what addr >> 63 is.  With this change the patch should be fine.

Isn't (addr >> 63) supposed to be 1? How can it be -1?

-- 
Pranith



reply via email to

[Prev in Thread] Current Thread [Next in Thread]