[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/7] vl: Error messages need to go to stderr, fix som
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 1/7] vl: Error messages need to go to stderr, fix some |
Date: |
Mon, 20 Jun 2016 17:00:17 +0200 |
We print a few fatal error messages to stdout instead of stderr.
Reproducer:
$ qemu-system-x86_64 -g 1024x768
Option g not supported for this target
$ qemu-system-x86_64 -g 1024x768 >/dev/null
Fix by printing them with error_report(). This also improves the messages.
The above one becomes
qemu-system-x86_64: -g 1024x768: Option not supported for this target
Reported-by: Tobi {github.com/tobimensch}
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
---
vl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index 2f63eb4..18af70a 100644
--- a/vl.c
+++ b/vl.c
@@ -3068,7 +3068,7 @@ int main(int argc, char **argv, char **envp)
popt = lookup_opt(argc, argv, &optarg, &optind);
if (!(popt->arch_mask & arch_type)) {
- printf("Option %s not supported for this target\n",
popt->name);
+ error_report("Option not supported for this target");
exit(1);
}
switch(popt->index) {
@@ -3846,21 +3846,21 @@ int main(int argc, char **argv, char **envp)
break;
case QEMU_OPTION_xen_domid:
if (!(xen_available())) {
- printf("Option %s not supported for this target\n",
popt->name);
+ error_report("Option not supported for this target");
exit(1);
}
xen_domid = atoi(optarg);
break;
case QEMU_OPTION_xen_create:
if (!(xen_available())) {
- printf("Option %s not supported for this target\n",
popt->name);
+ error_report("Option not supported for this target");
exit(1);
}
xen_mode = XEN_CREATE;
break;
case QEMU_OPTION_xen_attach:
if (!(xen_available())) {
- printf("Option %s not supported for this target\n",
popt->name);
+ error_report("Option not supported for this target");
exit(1);
}
xen_mode = XEN_ATTACH;
--
2.5.5
- [Qemu-devel] [PULL 0/7] Error reporting patches for 2016-06-20, Markus Armbruster, 2016/06/20
- [Qemu-devel] [PULL 1/7] vl: Error messages need to go to stderr, fix some,
Markus Armbruster <=
- [Qemu-devel] [PULL 3/7] error: Remove unnecessary local_err variables, Markus Armbruster, 2016/06/20
- [Qemu-devel] [PULL 5/7] log: Plug memory leak on multiple -dfilter, Markus Armbruster, 2016/06/20
- [Qemu-devel] [PULL 7/7] log: Fix qemu_set_log_filename() error handling, Markus Armbruster, 2016/06/20
- [Qemu-devel] [PULL 4/7] coccinelle: Remove unnecessary variables for function return value, Markus Armbruster, 2016/06/20
- [Qemu-devel] [PULL 2/7] error: Remove NULL checks on error_propagate() calls, Markus Armbruster, 2016/06/20
- [Qemu-devel] [PULL 6/7] log: Fix qemu_set_dfilter_ranges() error reporting, Markus Armbruster, 2016/06/20
- Re: [Qemu-devel] [PULL 0/7] Error reporting patches for 2016-06-20, Peter Maydell, 2016/06/20