Re: [Qemu-devel] [PATCH] rbd: reload ceph config for block device

[Vaibhav Bhembre]

On Mon, Jun 20, 2016 at 12:34 PM, Eric Blake <address@hidden> wrote:

> On 06/17/2016 08:28 PM, Vaibhav Bhembre wrote:
> > This patch adds ability to reload ceph configuration for an attached RBD
> > block device. This is necessary for the cases where rebooting a VM and/or
> > detaching-reattaching a RBD drive is not an easy option.
> >
> > The reload mechanism relies on the bdrv_reopen_* calls to provide a
> transactional
>
> > +++ b/qapi-schema.json
> > @@ -4308,3 +4308,16 @@
> >  # Since: 2.7
> >  ##
> >  { 'command': 'query-hotpluggable-cpus', 'returns': ['HotpluggableCPU'] }
> > +
> > +##
> > +# @reload-rbd-config
> > +#
> > +# Reload the ceph config for a given RBD block device attached to the
> VM.
> > +#
> > +# @device: Name of the device.
> > +#
> > +# Returns: nothing on success.
> > +#
> > +# Since: 2.5
>
> You've missed 2.5 by a long shot. This should be 2.7.
>

​True. I will update.

>
> > +##
> > +{'command': 'reload-rbd-config', 'data': { 'device': 'str' } }
>
> Would 'node' be a better name than 'device'? Isn't this really reloading
> the state of an arbitrary BDS node, regardless of whether (or even if)
> there is a BB device using that BDS?
>

​That is correct. It will update the state of a BDS node irrespective of
the device. I will make this change.​


>
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
>