Re: [Qemu-devel] [PATCH v4 3/3] i386: publish advised value of MSR_IA32_FEATURE_CONTROL via fw_cfg

[Laszlo Ersek]

On 06/22/16 12:18, Haozhong Zhang wrote:
> On 06/17/16 19:31, Laszlo Ersek wrote:
>> Hi Haozhong,
>>
>> On 06/16/16 13:19, Haozhong Zhang wrote:
>>> On 06/16/16 11:52, Paolo Bonzini wrote:
> [..]
>>>> Have you prepared a patch for SeaBIOS already?
>>>
>>> Yes, I'll send it after I fix the type error (uint32_t => uint64_t) in
>>> next version.
>>
>> This should be supported by OVMF as well (thanks Paolo for the heads-up).
>>
>> I'm glad to code that up, but I'd like to ask you to file an RFE
>> (Request For Enhancement) in the upstream edk2 tracker for OVMF:
>>
>> https://github.com/tianocore/edk2/issues/new
>>
>> In the RFE,
>> - the subject line should include "OvmfPkg",
>> - please describe what the feature is good for (going into the details
>>   of a specific use case is welcome),
>> - please specify the pathname and the internal format of the fw_cfg
>>   file,
>> - please clarify if this MSR is considered part of the "chipset state"
>>   that the firmware is responsible for at *every* boot. In particular
>>   whether you expect that the firmware program this MSR at S3 resume as
>>   well.
>>
> 
> Done. Pls check https://github.com/tianocore/edk2/issues/97.

Thanks. Looks good. I asked a few more questions in there. Especially if
the APs are involved in this, then the feature is going to be
significantly more complex than I expected.

Thanks
Laszlo