[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] qapi: Fix up cpu hotplug property names
|
From: |
David Gibson |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] qapi: Fix up cpu hotplug property names and add witness for cpu hotplug support |
|
Date: |
Fri, 24 Jun 2016 15:38:51 +1000 |
On Fri, 24 Jun 2016 07:31:39 +0200
Igor Mammedov <address@hidden> wrote:
> On Fri, 24 Jun 2016 13:00:56 +1000
> David Gibson <address@hidden> wrote:
>
> > On Thu, 23 Jun 2016 23:23:32 +0200
> > Peter Krempa <address@hidden> wrote:
> >
> > > Version 2:
> > > - fix typos/incompetence/drowsiness based language errors in commit
> > > message
> > > - select version 1 as prefered way
> > > - add -id suffix to all members of CpuInstanceProperties
> > > - note in qapi-schema the need to keep members in sync
> > > - fix output text field names in HMP impl
> > >
> > > Peter Krempa (2):
> > > qapi: Report support for -device cpu hotplug in query-machines
> > > qapi: keep names in 'CpuInstanceProperties' in sync with struct
> > > CPUCore
> >
> > Adding Bharata to CC.
> >
> > Igor, should I take these through my tree?
> Yep, please do so.
> It' would be even better if it's merged into master ASAP
> (for libvirt and for x86 device_add series that introduces these
> properties for x86 CPUs)
Yes, that's my intention. Just want to check what the final word is on
whether we need the extra witness, or whether checking what's returned
from query-hotpluggable-cpus is sufficient.
--
David Gibson <address@hidden>
Senior Software Engineer, Virtualization, Red Hat
pgpKF50asyqOG.pgp
Description: OpenPGP digital signature