[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v2 2/5] tests: New make target check-source
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH RFC v2 2/5] tests: New make target check-source |
Date: |
Tue, 28 Jun 2016 09:33:28 +0100 |
On 28 June 2016 at 09:19, Markus Armbruster <address@hidden> wrote:
> Peter Maydell <address@hidden> writes:
>
>> On 27 June 2016 at 07:34, Markus Armbruster <address@hidden> wrote:
>>> Peter Maydell <address@hidden> writes:
>>>> This is third-party code. We're not going to change it, so
>>>> we should avoid scanning it rather than adding tags which
>>>> will get lost next time we do an update to a new upstream
>>>> version...
>>>
>>> I can revive v1's blacklist for this directory. Any others?
>>
>> The clean-includes blacklist is
>> XDIRREGEX='^(tests/tcg|tests/multiboot|pc-bios|disas/libvixl)'
>>
>> (which covers both 3rd-party imports and code which is intended to
>> be built standalone and so doesn't follow QEMU's include
>> rules.)
>
> Noted.
>
> What about linux-headers/ and include/standard-headers/?
Mmm, clean-includes skips include/standard-headers (as a case
in the switch statement, not via the blacklist regex). It
doesn't skip linux-headers, though arguably it should. I think
it just never complained about anything in linux-headers so
I didn't identify it as something that needed to be skipped :-)
thanks
-- PMM
- Re: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers, (continued)
[Qemu-devel] [PATCH RFC] fixup! tests: New make target check-source, Markus Armbruster, 2016/06/30
Re: [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers, Sascha Silbe, 2016/06/27
- Re: [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers, Paolo Bonzini, 2016/06/27
- Re: [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers, Sascha Silbe, 2016/06/27
- Re: [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers, Markus Armbruster, 2016/06/28
- Re: [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers, John Snow, 2016/06/29
- Re: [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers, Markus Armbruster, 2016/06/30
- Re: [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers, John Snow, 2016/06/30