Re: [Qemu-devel] [PATCH] misc/aspeed_scu: Fix build error caused by missing header

[Peter Maydell]

On 28 June 2016 at 00:05, Andrew Jeffery <address@hidden> wrote:
> On Mon, 2016-06-27 at 17:53 -0400, Pranith Kumar wrote:
>> Tracing configurations error out currently as follows:
>>
>> /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c: In function 
>> ‘aspeed_scu_read’:
>> /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c:130:9: error: implicit 
>> declaration of function ‘qemu_log_mask’ 
>> [-Werror=implicit-function-declaration]
>> /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c:130:9: error: nested 
>> extern declaration of ‘qemu_log_mask’ [-Werror=nested-externs]
>> /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c:130:23: error: 
>> ‘LOG_GUEST_ERROR’ undeclared (first use in this function)
>> /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c:130:23: note: each 
>> undeclared identifier is reported only once for each function it appears in
>> /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c: In function 
>> ‘aspeed_scu_write’:
>> /home/travis/build/pranith/qemu/hw/misc/aspeed_scu.c:154:23: error: 
>> ‘LOG_GUEST_ERROR’ undeclared (first use in this function)
>>
>> This is caused by a missing header file. Fix it.
>>
>> Signed-off-by: Pranith Kumar <address@hidden>
>
> Reviewed-by: Andrew Jeffery <address@hidden>
>
> Thanks for the fix. I've enabled travis on my github repo now,
> hopefully I'll catch this kind of issue before I send patches out. I
> need to look into why I didn't trigger this issue in my own
> change/build/test cycles.

It only happens with certain trace backends. The default
trace backend will pull in qemu/log.h via trace.h.

thanks
-- PMM