[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/7] virtio: Merge virtio-{blk, scsi} host no
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/7] virtio: Merge virtio-{blk, scsi} host notifier handling paths |
Date: |
Tue, 28 Jun 2016 16:18:04 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Fri, Jun 24, 2016 at 08:39:27PM +0800, Fam Zheng wrote:
> v2: Only convert virtio-{blk,scsi}. [Paolo]
>
> This series is based on top of Cornelia's
>
> [PATCH 0/6] virtio: refactor host notifiers
>
> The benifit is we don't use event_notifier_set_handler even in non-dataplane
> now, which in turn makes virtio-blk and virtio-scsi follow block layer aio
> context semantics. Specifically, I/O requests must come from
> blk_get_aio_context(blk) events, rather than iohandler_get_aio_context(), so
> that bdrv_drained_begin/end will work as expected.
>
> Patch 4 reverts the hack (ab27c3b5e7) we added for 2.6. Lately, commit
> b880481579 added another pair of bdrv_drained_begin/end so the crash cannot
> happen even without ab27c3b5e7, but in order to avoid leaking requests, patch
> two is still a must.
Looks good overall. I have left comments.
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v2 4/7] virtio: Use aio_set_event_notifier for aio vq, (continued)
- [Qemu-devel] [PATCH v2 4/7] virtio: Use aio_set_event_notifier for aio vq, Fam Zheng, 2016/06/24
- [Qemu-devel] [PATCH v2 2/7] virtio: Add typedef for handle_output, Fam Zheng, 2016/06/24
- [Qemu-devel] [PATCH v2 3/7] virtio: Introduce virtio_add_queue_aio, Fam Zheng, 2016/06/24
- [Qemu-devel] [PATCH v2 6/7] virtio-scsi: Call virtio_add_queue_aio, Fam Zheng, 2016/06/24
- [Qemu-devel] [PATCH v2 5/7] virtio-blk: Call virtio_add_queue_aio, Fam Zheng, 2016/06/24
- [Qemu-devel] [PATCH v2 7/7] Revert "mirror: Workaround for unexpected iohandler events during completion", Fam Zheng, 2016/06/24
- Re: [Qemu-devel] [PATCH v2 0/7] virtio: Merge virtio-{blk, scsi} host notifier handling paths,
Stefan Hajnoczi <=