[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 01/11] stream: Fix prototype of stream_start()
From: |
Alberto Garcia |
Subject: |
[Qemu-devel] [PATCH v3 01/11] stream: Fix prototype of stream_start() |
Date: |
Fri, 1 Jul 2016 18:51:59 +0300 |
'stream-start' has a parameter called 'backing-file', which is the
string to be written to bs->backing when the job finishes.
In the stream_start() implementation it is called 'backing_file_str',
but it the prototype in the header file it is called 'base_id'.
This patch fixes it so the name is the same in both cases and is
consistent with other cases (like commit_start()).
Signed-off-by: Alberto Garcia <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
---
include/block/block_int.h | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 2057156..549b1ed 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -625,8 +625,8 @@ int is_windows_drive(const char *filename);
* @bs: Block device to operate on.
* @base: Block device that will become the new base, or %NULL to
* flatten the whole backing file chain onto @bs.
- * @base_id: The file name that will be written to @bs as the new
- * backing file if the job completes. Ignored if @base is %NULL.
+ * @backing_file_str: The file name that will be written to @bs as the
+ * the new backing file if the job completes. Ignored if @base is %NULL.
* @speed: The maximum speed, in bytes per second, or 0 for unlimited.
* @on_error: The action to take upon error.
* @cb: Completion function for the job.
@@ -637,11 +637,12 @@ int is_windows_drive(const char *filename);
* in @bs, but allocated in any image between @base and @bs (both
* exclusive) will be written to @bs. At the end of a successful
* streaming job, the backing file of @bs will be changed to
- * @base_id in the written image and to @base in the live BlockDriverState.
+ * @backing_file_str in the written image and to @base in the live
+ * BlockDriverState.
*/
void stream_start(BlockDriverState *bs, BlockDriverState *base,
- const char *base_id, int64_t speed, BlockdevOnError on_error,
- BlockCompletionFunc *cb,
+ const char *backing_file_str, int64_t speed,
+ BlockdevOnError on_error, BlockCompletionFunc *cb,
void *opaque, Error **errp);
/**
--
2.8.1
- [Qemu-devel] [PATCH v3 02/11] blockjob: Update description of the 'id' field, (continued)
- [Qemu-devel] [PATCH v3 09/11] commit: Add 'job-id' parameter to 'block-commit', Alberto Garcia, 2016/07/01
- [Qemu-devel] [PATCH v3 05/11] blockjob: Add 'job_id' parameter to block_job_create(), Alberto Garcia, 2016/07/01
- [Qemu-devel] [PATCH v3 01/11] stream: Fix prototype of stream_start(),
Alberto Garcia <=
- [Qemu-devel] [PATCH v3 06/11] mirror: Add 'job-id' parameter to 'blockdev-mirror' and 'drive-mirror', Alberto Garcia, 2016/07/01
- [Qemu-devel] [PATCH v3 11/11] blockjob: Update description of the 'device' field in the QMP API, Alberto Garcia, 2016/07/01
- [Qemu-devel] [PATCH v3 07/11] backup: Add 'job-id' parameter to 'blockdev-backup' and 'drive-backup', Alberto Garcia, 2016/07/01
- [Qemu-devel] [PATCH v3 03/11] blockjob: Add block_job_get(), Alberto Garcia, 2016/07/01
- [Qemu-devel] [PATCH v3 08/11] stream: Add 'job-id' parameter to 'block-stream', Alberto Garcia, 2016/07/01
- Re: [Qemu-devel] [PATCH v3 00/11] Allow creating block jobs with a user-defined ID, Kevin Wolf, 2016/07/04