Re: [Qemu-devel] [PATCH 1/2 V3] hmp: use snapshot name to determine whether a snapshot is 'fully available'

[Max Reitz]

On 29.06.2016 09:43, Lin Ma wrote:
> Currently qemu uses snapshot id to determine whether a snapshot is fully
> available, It causes incorrect output in some scenario.
> 
> For instance:
> (qemu) info block
> drive_image1 (#block113): /opt/vms/SLES12-SP1-JeOS-x86_64-GM/disk0.qcow2
> (qcow2)
>     Cache mode:       writeback
> 
> drive_image2 (#block349): /opt/vms/SLES12-SP1-JeOS-x86_64-GM/disk1.qcow2
> (qcow2)
>     Cache mode:       writeback
> (qemu)
> (qemu) info snapshots
> There is no snapshot available.
> (qemu)
> (qemu) snapshot_blkdev_internal drive_image1 snap1
> (qemu)
> (qemu) info snapshots
> There is no suitable snapshot available
> (qemu)
> (qemu) savevm checkpoint-1
> (qemu)
> (qemu) info snapshots
> ID        TAG                 VM SIZE                DATE       VM CLOCK
> 1         snap1                     0 2016-05-22 16:57:31   00:01:30.567
> (qemu)
> 
> $ qemu-img snapshot -l disk0.qcow2
> Snapshot list:
> ID        TAG                 VM SIZE                DATE       VM CLOCK
> 1         snap1                     0 2016-05-22 16:57:31   00:01:30.567
> 2         checkpoint-1           165M 2016-05-22 16:58:07   00:02:06.813
> 
> $ qemu-img snapshot -l disk1.qcow2
> Snapshot list:
> ID        TAG                 VM SIZE                DATE       VM CLOCK
> 1         checkpoint-1              0 2016-05-22 16:58:07   00:02:06.813
> 
> The patch uses snapshot name instead of snapshot id to determine whether a
> snapshot is fully available and uses '--' instead of snapshot id in output
> because the snapshot id is not guaranteed to be the same on all images.
> For instance:
> (qemu) info snapshots
> List of snapshots present on all disks:
>  ID        TAG                 VM SIZE                DATE       VM CLOCK
>  --        checkpoint-1           165M 2016-05-22 16:58:07   00:02:06.813
> 
> Signed-off-by: Lin Ma <address@hidden>
> ---
> Reviewed-by: Max Reitz

Everything below the --- until the first "diff" line is ignored by git
when applying. Thus it is useful space to put comments in that should
not appear in the commit message.

However, Reviewed-by tags are generally supposed to be in the commit
message, so they should be placed above the --- line. Also, they should
include the email address (just like the Signed-off-by tag).

Anyway, the maintainer who's going to apply this can fix that (although
I'm not sure yet who it's going to be).

Max

signature.asc
Description: OpenPGP digital signature