[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/15] qapi: use mmap for QmpInputVisitor
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 07/15] qapi: use mmap for QmpInputVisitor |
Date: |
Mon, 4 Jul 2016 11:02:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 30/06/2016 16:12, Markus Armbruster wrote:
> Implementing a stack as "big enough" array can be wasteful.
> Implementing it as dynamically allocated list is differently wasteful.
> Saving several mallocs and frees can be worth "wasting" a few pages of
> memory for a short time.
Most usage of QmpInputVisitor at startup comes from
object_property_set_qobject, which only sets small scalar objects. The
stack is entirely unused in this case.
Paolo
- Re: [Qemu-devel] [PATCH 07/15] qapi: use mmap for QmpInputVisitor,
Paolo Bonzini <=