Re: [Qemu-devel] [PATCH v3 10/11] qemu-img: Set the ID of the block job in img_commit()

[Alberto Garcia]

On Sat 02 Jul 2016 04:21:33 PM CEST, Max Reitz wrote:
> On 01.07.2016 17:52, Alberto Garcia wrote:
>> img_commit() creates a block job without an ID. This is no longer
>> allowed now that we require it to be unique and well-formed. We were
>> solving this by having a fallback in block_job_create(), but now that
>> we extended the API of commit_active_start() we can finally set an
>> explicit ID and revert that change.
>> 
>> Signed-off-by: Alberto Garcia <address@hidden>
>> ---
>>  blockjob.c | 6 ------
>>  qemu-img.c | 2 +-
>>  2 files changed, 1 insertion(+), 7 deletions(-)
>> 
>> diff --git a/blockjob.c b/blockjob.c
>> index 511c0db..3b9cec7 100644
>> --- a/blockjob.c
>> +++ b/blockjob.c
>> @@ -132,12 +132,6 @@ void *block_job_create(const char *job_id, const 
>> BlockJobDriver *driver,
>>  
>>      if (job_id == NULL) {
>>          job_id = bdrv_get_device_name(bs);
>> -        /* Assign a default ID if the BDS does not have a device
>> -         * name. We'll get rid of this soon when we finish extending
>> -         * the API of all commands that create block jobs. */
>> -        if (job_id[0] == '\0') {
>> -            job_id = "default_job";
>> -        }
>
> I think keeping an assertion here makes sense, though.

I don't think so, this is an optional parameter. If the user fails to
provide an ID when making the QMP call and there's no device name, QEMU
should simply return an error.

Berto