[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes()
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes() |
Date: |
Tue, 5 Jul 2016 15:39:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 05/07/2016 15:03, Eric Blake wrote:
> bs->bl.pwrite_zeroes_alignment =
> - iscsilun->bl.opt_unmap_gran * iscsilun->block_size;
> + pow2floor(iscsilun->bl.opt_unmap_gran * iscsilun->block_size);
> } else {
> bs->bl.pwrite_zeroes_alignment = iscsilun->block_size;
> }
> bs->bl.opt_transfer_length =
> - sector_limits_lun2qemu(iscsilun->bl.opt_xfer_len, iscsilun);
> + pow2floor(sector_limits_lun2qemu(iscsilun->bl.opt_xfer_len,
> iscsilun));
I see no reason why the alignment needs to be a power of two in
block/io.c, if you use / % * instead of &.
Paolo
- [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes(), Peter Lieven, 2016/07/04
- Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes(), Eric Blake, 2016/07/04
- Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes(), Paolo Bonzini, 2016/07/05
- Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes(), Peter Lieven, 2016/07/05
- Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes(), Eric Blake, 2016/07/05
- Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes(), Paolo Bonzini, 2016/07/05
- Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes(), Peter Lieven, 2016/07/15
- Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes(), Eric Blake, 2016/07/15
- Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes(), Peter Lieven, 2016/07/18
Re: [Qemu-devel] Regression: block: Add .bdrv_co_pwrite_zeroes(), Eric Blake, 2016/07/20