[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] main-loop: check return value before usi
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] main-loop: check return value before using |
Date: |
Wed, 6 Jul 2016 13:03:49 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 06/07/2016 12:08, Cao jin wrote:
> pointer 'qemu_aio_context' should be checked first before it is used.
> qemu_bh_new() will use it.
>
> Signed-off-by: Cao jin <address@hidden>
> ---
> main-loop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/main-loop.c b/main-loop.c
> index 89a6994..6a7f8d3 100644
> --- a/main-loop.c
> +++ b/main-loop.c
> @@ -154,11 +154,11 @@ int qemu_init_main_loop(Error **errp)
> }
>
> qemu_aio_context = aio_context_new(&local_error);
> - qemu_notify_bh = qemu_bh_new(notify_event_cb, NULL);
> if (!qemu_aio_context) {
> error_propagate(errp, local_error);
> return -EMFILE;
> }
> + qemu_notify_bh = qemu_bh_new(notify_event_cb, NULL);
> gpollfds = g_array_new(FALSE, FALSE, sizeof(GPollFD));
> src = aio_get_g_source(qemu_aio_context);
> g_source_attach(src, NULL);
>
Looks good, thanks!
Paolo